hello. i’m a happy user of lemmy.today.

i’ve always used the mlmym frontend available on old.lemmy.today, it generally works well enough. however, there are some minor minor bugs and missing features. (e.g. impossible to navigate to next page when viewing saved posts, impossible to see down/upvotes separated)

i recently came across this fork of mlmym (from this github issue) and it seems to have all those bugs fixed. can we replace the current mlmym with this fork?

thanks for reading

  • mrmanager@lemmy.todayM
    link
    fedilink
    arrow-up
    2
    ·
    edit-2
    4 months ago

    Yes, let’s do it.

    And sorry for the late response, I didn’t see this post until I got a private message about it.

    Will try and get it up today.

    Edit: And its up. I enabled the SHOW_UNREAD_COMMENTS option as well.

    • hexagonwin@lemmy.todayOP
      link
      fedilink
      arrow-up
      2
      ·
      4 months ago

      thanks a lot! it seems to work well :)

      edit: for some reason the communities bar on the top doesn’t seem to work properly :( before there was a list of all subscripbed communities, now it’s blank…

      • mrmanager@lemmy.todayM
        link
        fedilink
        arrow-up
        2
        ·
        4 months ago

        Hmm, that’s not good… Could be a bug in this version perhaps… Will have to roll back if I can’t fix it somehow.

        • hexagonwin@lemmy.todayOP
          link
          fedilink
          arrow-up
          3
          ·
          4 months ago

          i tried compiling it locally and there’s the same issue. however it seems to appear in certain conditions but disappear again on a refresh…

          now that we’ve rolled back, i’ll let you know again if this bug gets solved.

          thanks a lot

          • mrmanager@lemmy.todayM
            link
            fedilink
            arrow-up
            2
            ·
            4 months ago

            Ok see if you can report it to the author who posted in this thread. Once its fixed we can make another attempt. :)

          • mrmanager@lemmy.todayM
            link
            fedilink
            arrow-up
            2
            ·
            4 months ago

            Perhaps it works now for you. I made some changes to the networking that was causing it to run slow, perhaps that also created your issues. If you hold shift and click reload in the browser to skip the browser cache, perhaps that will also work.

            Is it the top bar in this picture you dont see?

            • hexagonwin@lemmy.todayOP
              link
              fedilink
              arrow-up
              2
              ·
              4 months ago

              yes, the top bar (technology lemmyshitpost memes me_irl …). it seems be working now for some reason, thanks

              edit: hmm now comment scores aren’t showing lmao. maybe there’s something wrong with my browser?.. seems like something’s buggy…

              • mschae@discuss.mschae23.de
                link
                fedilink
                English
                arrow-up
                1
                ·
                4 months ago

                hmm now comment scores aren’t showing lmao. maybe there’s something wrong with my browser?.. seems like something’s buggy…

                That looks like you have “show scores” disabled in the preferences? Can’t think of any other reason they wouldn’t be showing like this.

                Also, if you’re wondering about the “also show on comments” option for upvote/downvote totals, I found that too distracting to show on every comment, so that extra information is only shown when there are actually both upvotes and downvotes.

                • hexagonwin@lemmy.todayOP
                  link
                  fedilink
                  English
                  arrow-up
                  2
                  ·
                  4 months ago

                  That looks like you have “show scores” disabled in the preferences? Can’t think of any other reason they wouldn’t be showing like this.

                  “show scores” was already enabled, but disabling -> saving -> enabling fixed it, i guess the settings for my account was in a weird state. it’s all resolved now, thanks!

                  ok seems like i said that too early, the top bar disappearing issue came back, lol. it seems to work a few times randomly… it isn’t a critical bug so i’ll keep using and investigating.

                  the ‘my communities’ button always seems to work

                  • mrmanager@lemmy.todayM
                    link
                    fedilink
                    arrow-up
                    1
                    ·
                    4 months ago

                    Try to hold shift and reload the entire old.lemmy.today site in the browser. It’s possible the old mlmym and this new one are conflicting somehow.

                    I also changed a lot of stuff with networking for it, so it’s faster now I think.

                    If you still have problems, try a different browser just to see if it works there. Then we know it’s a browser issue if it does.

                  • mschae@discuss.mschae23.de
                    link
                    fedilink
                    English
                    arrow-up
                    1
                    ·
                    4 months ago

                    You said it only appears sometimes and it fixes itself on refreshes, right? I think that would rule out a mistake in the templates somewhere (which would’ve meant that it’s consistently failing on some pages).

                    I wonder what the HTML output looks like when you can reproduce it. Do the <a> elements for the links not get output at all (more likely) or are they hidden somehow?

                    I’m not really sure on why this would happen, to be honest.

        • mschae@discuss.mschae23.de
          link
          fedilink
          English
          arrow-up
          1
          ·
          4 months ago

          Hm, it’s working on my instance. I did change it to only make the search request for top communities once and cache it, so maybe that happened to run into an error and it’s not trying again?

          Running it locally on lemmy.today, it does seem to be working. I don’t have an account here, unfortunately, so I can’t test whether the “my communities” dropdown works too, but I don’t see why it shouldn’t.

    • mschae@lemmy.today
      link
      fedilink
      English
      arrow-up
      2
      ·
      4 months ago

      Oh, while you’re here, I think LANGUAGE_TAGS is also a good candidate to turn on by default (forgot to add it to the readme when I added the feature, so I also forgot about it in my earlier message…), and maybe SHOW_CONTROVERSIAL.

      There’s also EMBED_METADATA for embeds (for links on Discord and such) to show, but I don’t know if you want that.